zend_inheritance: Improve placement of return-by-ref & in zend_get_function_declaration()
#20104
Conversation
…function_declaration() The space after `&` looked super odd. Remove it and put the `&` right before the function name (after the class name), matching the actual syntax for declaring a by-ref return.
| ?> | ||
| --EXPECTF-- | ||
| Fatal error: Declaration of A::$prop::get() must be compatible with & I::$prop::get() in %s on line %d | ||
| Fatal error: Declaration of A::$prop::get() must be compatible with I::&$prop::get() in %s on line %d |
There was a problem hiding this comment.
This one looks weird, as the signature of reference get hook is &get, not &$prop.
There was a problem hiding this comment.
Yeah, I had also seen that. This isn't quite trivial to fix, since it the technical method name is $prop::get as a single string. Moving the & in front of the class name (just removing the space) would work. My main issue is with the space.
/cc @Crell @iluuu1994
There was a problem hiding this comment.
Not sure what I think of this change, but I::$prop::&get() seems like the consistent option. I don't think I::&$prop::get() is better than what we currently have. But I also acknowledge this is likely not important enough to warrant a complex fix.
I think overall I'd prefer not to adjust the message at all (apart from maybe removing the space).
3 participants
The space after
&looked super odd. Remove it and put the&right before the function name (after the class name), matching the actual syntax for declaring a by-ref return.